Adding core-js#50
Closed
ThomasLandauer wants to merge 1 commit intosymfony:mainfrom
ThomasLandauer:patch-1
Closed
Conversation
Is this the right fix for #49 and #47 ? Thanks to @graceman9 and @Kocal, I solved it by doing `npm install --save core-js@3.19.0`. So I'm **guessing** it might be better to add it here right away.
Member
|
Hi, and thanks for the PR! I don't think this is the right fix for the Also, note that dependency |
Author
|
Don't know why it didn't work last week, but now (after starting from scratch) this is my {
"devDependencies": {
"@symfony/stimulus-bridge": "^2.0.0",
"@symfony/webpack-encore": "^1.0.0",
"core-js": "^3.0.0",
"regenerator-runtime": "^0.13.2",
"stimulus": "^2.0.0",
"webpack-notifier": "^1.6.0"
},
"license": "UNLICENSED",
"private": true,
"scripts": {
"dev-server": "encore dev-server",
"dev": "encore dev",
"watch": "encore dev --watch",
"build": "encore production --progress"
}
}Everything fine so far, so I'm closing this :-) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is this the right fix for #49 and #47 ? Thanks to @graceman9 and @Kocal, I solved it by doing
npm install --save core-js@3.19.0.So I'm guessing it might be better to add it here right away.
Closes #49